From ceb03cfb037cf7024a5048b17b508ddda59cfa05 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Tue, 13 Jun 2023 16:45:06 +0100 Subject: refactor(core): cleanup feature flags for js source inclusion (#19463) Remove `ExtensionFileSourceCode::LoadedFromFsDuringSnapshot` and feature `include_js_for_snapshotting` since they leak paths that are only applicable in this repo to embedders. Replace with feature `exclude_js_sources`. Additionally the feature `force_include_js_sources` allows negating it, if both features are set. We need both of these because features are additive and there must be a way of force including sources for snapshot creation while still having the `exclude_js_sources` feature. `force_include_js_sources` is only set for build deps, so sources are still excluded from the final binary. You can also specify `force_include_js_sources` on any extension to override the above features for that extension. Towards #19398. But there was still the snapshot-from-snapshot situation where code could be executed twice, I addressed that by making `mod_evaluate()` and scripts like `core/01_core.js` behave idempotently. This allowed unifying `ext::init_ops()` and `ext::init_ops_and_esm()` into `ext::init()`. --- runtime/Cargo.toml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'runtime/Cargo.toml') diff --git a/runtime/Cargo.toml b/runtime/Cargo.toml index 77571b210..e66698a01 100644 --- a/runtime/Cargo.toml +++ b/runtime/Cargo.toml @@ -14,15 +14,8 @@ description = "Provides the deno runtime library" docsrs = [] # A feature that disables creation of startup snapshot during in the build script. dont_create_runtime_snapshot = [] -# A feature that changes how startup snapshot is generated, that allows -# extending it in embedder crates. -snapshot_from_snapshot = [] -# A feature that disables embedding of the JavaScript source files in the binary. -# With this feature enabled, the sources must be consumed during build time, -# by creating a startup snapshot. -include_js_files_for_snapshotting = [ - "deno_core/include_js_files_for_snapshotting", -] +# Enable to exclude `js/99_main.js` from the generated snapshot. +exclude_js_main_from_snapshot = [] [lib] name = "deno_runtime" -- cgit v1.2.3