From fcdcc8c0c3316857e327bb3c0109fd244f1ec409 Mon Sep 17 00:00:00 2001
From: Divy Srivastava <dj.srivastava23@gmail.com>
Date: Sat, 26 Nov 2022 06:37:43 -0800
Subject: feat(ops): support raw pointer arguments (#16826)

See https://github.com/denoland/deno/pull/16814#discussion_r1032744083.
Allows nullable buffers in low-level ops like FFI:

```rust
fn op_ffi_ptr_of<FP>(
  state: &mut OpState,
  buf: *const u8,
  out: &mut [u32],
)
where
  FP: FfiPermissions + 'static {
  // ..
}
```
---
 ops/optimizer_tests/raw_ptr.expected | 10 +++++++
 ops/optimizer_tests/raw_ptr.out      | 55 ++++++++++++++++++++++++++++++++++++
 ops/optimizer_tests/raw_ptr.rs       |  6 ++++
 3 files changed, 71 insertions(+)
 create mode 100644 ops/optimizer_tests/raw_ptr.expected
 create mode 100644 ops/optimizer_tests/raw_ptr.out
 create mode 100644 ops/optimizer_tests/raw_ptr.rs

(limited to 'ops/optimizer_tests')

diff --git a/ops/optimizer_tests/raw_ptr.expected b/ops/optimizer_tests/raw_ptr.expected
new file mode 100644
index 000000000..12577eb77
--- /dev/null
+++ b/ops/optimizer_tests/raw_ptr.expected
@@ -0,0 +1,10 @@
+=== Optimizer Dump ===
+returns_result: false
+has_ref_opstate: true
+has_rc_opstate: false
+has_fast_callback_option: true
+fast_result: Some(Void)
+fast_parameters: [V8Value, Uint8Array, Uint32Array]
+transforms: {1: Transform { kind: PtrU8, index: 1 }, 2: Transform { kind: SliceU32(true), index: 2 }}
+is_async: false
+fast_compatible: true
diff --git a/ops/optimizer_tests/raw_ptr.out b/ops/optimizer_tests/raw_ptr.out
new file mode 100644
index 000000000..30943d67d
--- /dev/null
+++ b/ops/optimizer_tests/raw_ptr.out
@@ -0,0 +1,55 @@
+struct op_ffi_ptr_of_fast<FP> {
+    _phantom: ::std::marker::PhantomData<FP>,
+}
+impl<'scope, FP> deno_core::v8::fast_api::FastFunction for op_ffi_ptr_of_fast<FP>
+where
+    FP: FfiPermissions + 'static,
+{
+    fn function(&self) -> *const ::std::ffi::c_void {
+        op_ffi_ptr_of_fast_fn::<FP> as *const ::std::ffi::c_void
+    }
+    fn args(&self) -> &'static [deno_core::v8::fast_api::Type] {
+        use deno_core::v8::fast_api::Type::*;
+        use deno_core::v8::fast_api::CType;
+        &[V8Value, TypedArray(CType::Uint8), TypedArray(CType::Uint32), CallbackOptions]
+    }
+    fn return_type(&self) -> deno_core::v8::fast_api::CType {
+        deno_core::v8::fast_api::CType::Void
+    }
+}
+fn op_ffi_ptr_of_fast_fn<'scope, FP>(
+    _: deno_core::v8::Local<deno_core::v8::Object>,
+    buf: *const deno_core::v8::fast_api::FastApiTypedArray<u8>,
+    out: *const deno_core::v8::fast_api::FastApiTypedArray<u32>,
+    fast_api_callback_options: *mut deno_core::v8::fast_api::FastApiCallbackOptions,
+) -> ()
+where
+    FP: FfiPermissions + 'static,
+{
+    use deno_core::v8;
+    use deno_core::_ops;
+    let __opts: &mut v8::fast_api::FastApiCallbackOptions = unsafe {
+        &mut *fast_api_callback_options
+    };
+    let __ctx = unsafe {
+        &*(v8::Local::<v8::External>::cast(unsafe { __opts.data.data }).value()
+            as *const _ops::OpCtx)
+    };
+    let state = &mut ::std::cell::RefCell::borrow_mut(&__ctx.state);
+    let buf = match unsafe { &*buf }.get_storage_if_aligned() {
+        Some(v) => v.as_ptr(),
+        None => {
+            unsafe { &mut *fast_api_callback_options }.fallback = true;
+            return Default::default();
+        }
+    };
+    let out = match unsafe { &*out }.get_storage_if_aligned() {
+        Some(v) => v,
+        None => {
+            unsafe { &mut *fast_api_callback_options }.fallback = true;
+            return Default::default();
+        }
+    };
+    let result = op_ffi_ptr_of::call::<FP>(state, buf, out);
+    result
+}
diff --git a/ops/optimizer_tests/raw_ptr.rs b/ops/optimizer_tests/raw_ptr.rs
new file mode 100644
index 000000000..249b3b35b
--- /dev/null
+++ b/ops/optimizer_tests/raw_ptr.rs
@@ -0,0 +1,6 @@
+fn op_ffi_ptr_of<FP>(state: &mut OpState, buf: *const u8, out: &mut [u32])
+where
+  FP: FfiPermissions + 'static,
+{
+  // ..
+}
-- 
cgit v1.2.3