From fbb69329343c9985c26181e6297e6556c46d381d Mon Sep 17 00:00:00 2001
From: Matt Mastracci <matthew@mastracci.com>
Date: Thu, 29 Jun 2023 10:23:14 -0600
Subject: refactor(ops): op2 support for generics (#19636)

Implementation of generics for `#[op2]`, along with some refactoring to
improve the ergonomics of ops with generics parameters:

- The ops have generics on the struct rather than the associated
methods, which allows us to trait-ify ops (impossible when they are on
the methods)
- The decl() method can become a trait-associated const field which
unlocks future optimizations

Callers of ops need to switch from:
`op_net_connect_tcp::call::<TestPermission>(conn_state, ip_addr)` to
`op_net_connect_tcp::<TestPermission>::call(conn_state, ip_addr)`.
---
 ops/optimizer_tests/strings_result.out | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

(limited to 'ops/optimizer_tests/strings_result.out')

diff --git a/ops/optimizer_tests/strings_result.out b/ops/optimizer_tests/strings_result.out
index 46e27e762..45ca1fac7 100644
--- a/ops/optimizer_tests/strings_result.out
+++ b/ops/optimizer_tests/strings_result.out
@@ -3,16 +3,29 @@
 ///
 ///Use `op_string_length::decl()` to get an op-declaration
 ///you can include in a `deno_core::Extension`.
-pub struct op_string_length;
+pub struct op_string_length {
+    _phantom_data: ::std::marker::PhantomData<()>,
+}
+impl deno_core::_ops::Op for op_string_length {
+    const NAME: &'static str = stringify!(op_string_length);
+    const DECL: deno_core::OpDecl = deno_core::OpDecl {
+        name: Self::name(),
+        v8_fn_ptr: Self::v8_fn_ptr as _,
+        enabled: true,
+        fast_fn: None,
+        is_async: false,
+        is_unstable: false,
+        is_v8: false,
+        arg_count: 0,
+    };
+}
 #[doc(hidden)]
 impl op_string_length {
     pub const fn name() -> &'static str {
         stringify!(op_string_length)
     }
     #[allow(clippy::not_unsafe_ptr_arg_deref)]
-    pub extern "C" fn v8_fn_ptr<'scope>(
-        info: *const deno_core::v8::FunctionCallbackInfo,
-    ) {
+    pub extern "C" fn v8_fn_ptr(info: *const deno_core::v8::FunctionCallbackInfo) {
         let info = unsafe { &*info };
         let scope = &mut unsafe { deno_core::v8::CallbackScope::new(info) };
         let args = deno_core::v8::FunctionCallbackArguments::from_function_callback_info(
@@ -21,7 +34,7 @@ impl op_string_length {
         let rv = deno_core::v8::ReturnValue::from_function_callback_info(info);
         Self::v8_func(scope, args, rv);
     }
-    pub const fn decl<'scope>() -> deno_core::OpDecl {
+    pub const fn decl() -> deno_core::OpDecl {
         deno_core::OpDecl {
             name: Self::name(),
             v8_fn_ptr: Self::v8_fn_ptr as _,
@@ -35,7 +48,8 @@ impl op_string_length {
     }
     #[inline]
     #[allow(clippy::too_many_arguments)]
-    fn call(string: &str) -> Result<u32, AnyError> {
+    #[allow(clippy::extra_unused_lifetimes)]
+    fn call<'scope>(string: &str) -> Result<u32, AnyError> {
         Ok(string.len() as u32)
     }
     pub fn v8_func<'scope>(
-- 
cgit v1.2.3