From 9b2b8df927ac23cfa99016a684179f2a3198ba2e Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Thu, 1 Dec 2022 21:29:15 -0800 Subject: feat(ops): Fast zero copy string arguments (#16777) Uses SeqOneByteString optimization to do zero-copy `&str` arguments in fast calls. - [x] Depends on https://github.com/denoland/rusty_v8/pull/1129 - [x] Depends on https://chromium-review.googlesource.com/c/v8/v8/+/4036884 - [x] Disable in async ops - [x] Make it work with owned `String` with an extra alloc in fast path. - [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast case ```rust #[op] fn op_string_len(s: &str) -> u32 { str.len() as u32 } ``` --- ops/optimizer_tests/strings.expected | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 ops/optimizer_tests/strings.expected (limited to 'ops/optimizer_tests/strings.expected') diff --git a/ops/optimizer_tests/strings.expected b/ops/optimizer_tests/strings.expected new file mode 100644 index 000000000..ead741054 --- /dev/null +++ b/ops/optimizer_tests/strings.expected @@ -0,0 +1,11 @@ +=== Optimizer Dump === +returns_result: false +has_ref_opstate: false +has_rc_opstate: false +has_fast_callback_option: false +needs_fast_callback_option: false +fast_result: Some(U32) +fast_parameters: [V8Value, SeqOneByteString] +transforms: {0: Transform { kind: SeqOneByteString(Ref), index: 0 }} +is_async: false +fast_compatible: true -- cgit v1.2.3