From fb358380c0570103619b0ce71c7fcb1b5a17986c Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 3 Feb 2021 11:40:43 +0100 Subject: fix: improve http client builder error message (#9380) Include the lower-level error message in the generic error message. No test because I can't actually make it fail by passing it bad PEM. I checked and `reqwest::Certificate::from_pem()` always returns `Ok()`. Fixes #9364. --- op_crates/fetch/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'op_crates') diff --git a/op_crates/fetch/lib.rs b/op_crates/fetch/lib.rs index 46c72e7a8..23f356a96 100644 --- a/op_crates/fetch/lib.rs +++ b/op_crates/fetch/lib.rs @@ -3,6 +3,7 @@ #![deny(warnings)] use deno_core::error::bad_resource_id; +use deno_core::error::generic_error; use deno_core::error::type_error; use deno_core::error::AnyError; use deno_core::futures::Future; @@ -433,5 +434,5 @@ fn create_http_client( } builder .build() - .map_err(|_| deno_core::error::generic_error("Unable to build http client")) + .map_err(|e| generic_error(format!("Unable to build http client: {}", e))) } -- cgit v1.2.3