From 83bece56b01f6997cb71e9289a4d83a398cde0c8 Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Sun, 25 Apr 2021 22:00:05 +0200 Subject: refactor(core): move op cache sync responsibility to rust space (#10340) Even if bootstrapping the JS runtime is low level, it's an abstraction leak of core to require users to call `Deno.core.ops()` in JS space. So instead we're introducing a `JsRuntime::sync_ops_cache()` method, once we have runtime extensions a new runtime will ensure the ops cache is setup (for the provided extensions) and then loading/unloading plugins should be the only operations that require op cache syncs --- op_crates/url/benches/url_ops.rs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'op_crates') diff --git a/op_crates/url/benches/url_ops.rs b/op_crates/url/benches/url_ops.rs index 37efb0a33..7d5d32879 100644 --- a/op_crates/url/benches/url_ops.rs +++ b/op_crates/url/benches/url_ops.rs @@ -15,6 +15,7 @@ fn create_js_runtime() -> JsRuntime { "op_url_stringify_search_params", op_sync(deno_url::op_url_stringify_search_params), ); + runtime.sync_ops_cache(); runtime .execute( @@ -23,14 +24,6 @@ fn create_js_runtime() -> JsRuntime { ) .unwrap(); deno_url::init(&mut runtime); - runtime - .execute( - "init", - r#" - Deno.core.ops(); - "#, - ) - .unwrap(); runtime .execute("setup", "const { URL } = globalThis.__bootstrap.url;") .unwrap(); -- cgit v1.2.3