From df54db77625e0e51b1d016fb8a1f89f7458a0584 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Fri, 1 Feb 2019 23:26:33 -0500 Subject: Fix v8_str internalize bug --- libdeno/binding.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'libdeno/binding.cc') diff --git a/libdeno/binding.cc b/libdeno/binding.cc index 6c636774a..d7fab6519 100644 --- a/libdeno/binding.cc +++ b/libdeno/binding.cc @@ -262,8 +262,8 @@ deno_mod DenoIsolate::RegisterModule(const char* name, const char* source) { auto context = context_.Get(isolate_); v8::Context::Scope context_scope(context); - v8::Local name_str = v8_str(name, true); - v8::Local source_str = v8_str(source, true); + v8::Local name_str = v8_str(name); + v8::Local source_str = v8_str(source); auto origin = ModuleOrigin(isolate_, name_str); v8::ScriptCompiler::Source source_(source_str, origin); @@ -341,8 +341,8 @@ bool Execute(v8::Local context, const char* js_filename, v8::HandleScope handle_scope(isolate); v8::Context::Scope context_scope(context); - auto source = v8_str(js_source, true); - auto name = v8_str(js_filename, true); + auto source = v8_str(js_source); + auto name = v8_str(js_filename); v8::TryCatch try_catch(isolate); @@ -423,8 +423,7 @@ void HostInitializeImportMetaObjectCallback(v8::Local context, const char* url = info->name.c_str(); - meta->CreateDataProperty(context, v8_str("url"), v8_str(url, true)) - .ToChecked(); + meta->CreateDataProperty(context, v8_str("url"), v8_str(url)).ToChecked(); } void DenoIsolate::AddIsolate(v8::Isolate* isolate) { -- cgit v1.2.3