From ad11f2ad6aae758e67734d60f068285fb5e10655 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Wed, 11 Sep 2019 21:20:54 +0100 Subject: Default base URL path to '/' (#2921) --- js/url.ts | 2 +- js/url_test.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'js') diff --git a/js/url.ts b/js/url.ts index a2562b9a3..f22198da4 100644 --- a/js/url.ts +++ b/js/url.ts @@ -333,7 +333,7 @@ export class URL { password: baseParts.password, hostname: baseParts.hostname, port: baseParts.port, - path: resolvePathFromBase(urlParts.path, baseParts.path), + path: resolvePathFromBase(urlParts.path, baseParts.path || "/"), query: urlParts.query, hash: urlParts.hash }; diff --git a/js/url_test.ts b/js/url_test.ts index c42025929..07a8028ce 100644 --- a/js/url_test.ts +++ b/js/url_test.ts @@ -152,6 +152,10 @@ test(function urlRelativeWithBase(): void { assertEquals(new URL("../b", "file:///a/a/a").href, "file:///a/b"); }); +test(function emptyBasePath(): void { + assertEquals(new URL("", "http://example.com").href, "http://example.com/"); +}); + test(function deletingAllParamsRemovesQuestionMarkFromURL(): void { const url = new URL("http://example.com/?param1¶m2"); url.searchParams.delete("param1"); -- cgit v1.2.3