From bbeb30fc5e6fdb461cd219f95efcc5c52ed16f30 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=BF=B7=E6=B8=A1?= <justjavac@gmail.com>
Date: Wed, 1 May 2019 02:25:37 +0800
Subject: Make `atob` follow the spec (#2242)

---
 js/text_encoding.ts | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

(limited to 'js/text_encoding.ts')

diff --git a/js/text_encoding.ts b/js/text_encoding.ts
index 883451631..03cc966b1 100644
--- a/js/text_encoding.ts
+++ b/js/text_encoding.ts
@@ -176,20 +176,28 @@ class UTF8Encoder implements Encoder {
 
 /** Decodes a string of data which has been encoded using base-64. */
 export function atob(s: string): string {
-  const rem = s.length % 4;
-  // base64-js requires length exactly times of 4
-  if (rem > 0) {
-    s = s.padEnd(s.length + (4 - rem), "=");
+  s = String(s);
+  s = s.replace(/[\t\n\f\r ]/g, "");
+
+  if (s.length % 4 === 0) {
+    s = s.replace(/==?$/, "");
   }
-  let byteArray;
-  try {
-    byteArray = base64.toByteArray(s);
-  } catch (_) {
+
+  const rem = s.length % 4;
+  if (rem === 1 || /[^+/0-9A-Za-z]/.test(s)) {
+    // TODO: throw `DOMException`
     throw new DenoError(
       ErrorKind.InvalidInput,
       "The string to be decoded is not correctly encoded"
     );
   }
+
+  // base64-js requires length exactly times of 4
+  if (rem > 0) {
+    s = s.padEnd(s.length + (4 - rem), "=");
+  }
+
+  const byteArray: Uint8Array = base64.toByteArray(s);
   let result = "";
   for (let i = 0; i < byteArray.length; i++) {
     result += String.fromCharCode(byteArray[i]);
-- 
cgit v1.2.3