From 1f2c92c7c88ce6619624520ec7e6b9a1f57d445b Mon Sep 17 00:00:00 2001
From: Ryan Dahl <ry@tinyclouds.org>
Date: Thu, 8 Nov 2018 01:18:21 -0500
Subject: Reader/Writer should use Uint8Array not ArrayBufferView

Because many Reader/Writer implementations (e.g. bufio) assume their
able to use subarray() with byte indexes and often ask for byte values,
it makes sense to simply restrict all implementations to Uint8Array.
---
 js/files.ts | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

(limited to 'js/files.ts')

diff --git a/js/files.ts b/js/files.ts
index 23fa8cc2d..ef0037511 100644
--- a/js/files.ts
+++ b/js/files.ts
@@ -9,11 +9,11 @@ import * as flatbuffers from "./flatbuffers";
 export class File implements Reader, Writer, Closer {
   constructor(readonly rid: number) {}
 
-  write(p: ArrayBufferView): Promise<number> {
+  write(p: Uint8Array): Promise<number> {
     return write(this.rid, p);
   }
 
-  read(p: ArrayBufferView): Promise<ReadResult> {
+  read(p: Uint8Array): Promise<ReadResult> {
     return read(this.rid, p);
   }
 
@@ -68,10 +68,7 @@ export async function open(
  *
  * Resolves with the `ReadResult` for the operation.
  */
-export async function read(
-  rid: number,
-  p: ArrayBufferView
-): Promise<ReadResult> {
+export async function read(rid: number, p: Uint8Array): Promise<ReadResult> {
   const builder = flatbuffers.createBuilder();
   msg.Read.startRead(builder);
   msg.Read.addRid(builder, rid);
@@ -88,7 +85,7 @@ export async function read(
  *
  * Resolves with the number of bytes written.
  */
-export async function write(rid: number, p: ArrayBufferView): Promise<number> {
+export async function write(rid: number, p: Uint8Array): Promise<number> {
   const builder = flatbuffers.createBuilder();
   msg.Write.startWrite(builder);
   msg.Write.addRid(builder, rid);
-- 
cgit v1.2.3