From 5f97c041d9115c480e3b9f428cfee27b109b3883 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=BF=B7=E6=B8=A1?= Date: Wed, 3 Apr 2019 20:38:50 +0800 Subject: fix console.log when error has been caught (#2041) --- js/console_test.ts | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) (limited to 'js/console_test.ts') diff --git a/js/console_test.ts b/js/console_test.ts index ed2f37548..7bedcf973 100644 --- a/js/console_test.ts +++ b/js/console_test.ts @@ -264,7 +264,7 @@ test(function consoleTestError() { } catch (e) { assert( stringify(e) - .split("\n")[3] + .split("\n")[0] // error has been caught .includes("MyError: This is an error") ); } @@ -593,3 +593,21 @@ test(function consoleTable() { assertEquals(out.toString(), "test\n"); }); }); + +// console.log(Error) test +test(function consoleLogShouldNotThrowError() { + let result = 0; + try { + console.log(new Error("foo")); + result = 1; + } catch (e) { + result = 2; + } + assertEquals(result, 1); + + // output errors to the console should not include "Uncaught" + mockConsole((console, out) => { + console.log(new Error("foo")); + assertEquals(out.toString().includes("Uncaught"), false); + }); +}); -- cgit v1.2.3