From 3a4a47799fe395a4ceb253c394724f54192150d2 Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Mon, 7 Jun 2021 10:04:10 +0200 Subject: refactor: clean up webidl protype configuration (#10871) --- extensions/web/01_dom_exception.js | 4 +-- extensions/web/03_abort_signal.js | 5 +++ extensions/web/08_text_encoding.js | 67 +++----------------------------------- 3 files changed, 10 insertions(+), 66 deletions(-) (limited to 'extensions/web') diff --git a/extensions/web/01_dom_exception.js b/extensions/web/01_dom_exception.js index f5bd3289b..e4bcb9fba 100644 --- a/extensions/web/01_dom_exception.js +++ b/extensions/web/01_dom_exception.js @@ -105,9 +105,7 @@ } } - defineProperty(DOMException.prototype, "message", { enumerable: true }); - defineProperty(DOMException.prototype, "name", { enumerable: true }); - defineProperty(DOMException.prototype, "code", { enumerable: true }); + webidl.configurePrototype(DOMException); for ( const [key, value] of Object.entries({ diff --git a/extensions/web/03_abort_signal.js b/extensions/web/03_abort_signal.js index 5d7e10bb2..6551380da 100644 --- a/extensions/web/03_abort_signal.js +++ b/extensions/web/03_abort_signal.js @@ -60,6 +60,9 @@ } } defineEventHandler(AbortSignal.prototype, "abort"); + + webidl.configurePrototype(AbortSignal); + class AbortController { #signal = new AbortSignal(illegalConstructorKey); @@ -76,6 +79,8 @@ } } + webidl.configurePrototype(AbortController); + const handlerSymbol = Symbol("eventHandlers"); function makeWrappedHandler(handler) { diff --git a/extensions/web/08_text_encoding.js b/extensions/web/08_text_encoding.js index be66e4981..0ba1bb582 100644 --- a/extensions/web/08_text_encoding.js +++ b/extensions/web/08_text_encoding.js @@ -121,23 +121,7 @@ } } - Object.defineProperty(TextDecoder.prototype, "encoding", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoder.prototype, "fatal", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoder.prototype, "ignoreBOM", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoder.prototype, "decode", { - enumerable: true, - writable: true, - configurable: true, - }); + webidl.configurePrototype(TextDecoder); class TextEncoder { constructor() { @@ -189,20 +173,7 @@ } } - Object.defineProperty(TextEncoder.prototype, "encoding", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextEncoder.prototype, "encode", { - enumerable: true, - writable: true, - configurable: true, - }); - Object.defineProperty(TextEncoder.prototype, "encodeInto", { - enumerable: true, - writable: true, - configurable: true, - }); + webidl.configurePrototype(TextEncoder); class TextDecoderStream { /** @type {TextDecoder} */ @@ -293,26 +264,7 @@ } } - Object.defineProperty(TextDecoderStream.prototype, "encoding", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoderStream.prototype, "fatal", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoderStream.prototype, "ignoreBOM", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoderStream.prototype, "readable", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextDecoderStream.prototype, "writable", { - enumerable: true, - configurable: true, - }); + webidl.configurePrototype(TextDecoderStream); class TextEncoderStream { /** @type {string | null} */ @@ -382,18 +334,7 @@ } } - Object.defineProperty(TextEncoderStream.prototype, "encoding", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextEncoderStream.prototype, "readable", { - enumerable: true, - configurable: true, - }); - Object.defineProperty(TextEncoderStream.prototype, "writable", { - enumerable: true, - configurable: true, - }); + webidl.configurePrototype(TextEncoderStream); webidl.converters.TextDecoderOptions = webidl.createDictionaryConverter( "TextDecoderOptions", -- cgit v1.2.3