From 7a41a939972b701e96cb70cbf0516595fefcae02 Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Wed, 18 Sep 2024 21:14:40 +0200 Subject: fix(ext/http): gracefully handle Response.error responses (#25712) Fixes #14371 --- ext/http/00_serve.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'ext') diff --git a/ext/http/00_serve.ts b/ext/http/00_serve.ts index 87798656f..6d23685d8 100644 --- a/ext/http/00_serve.ts +++ b/ext/http/00_serve.ts @@ -511,9 +511,15 @@ function mapToCallback(context, callback, onError) { ); } + if (response.type === "error") { + throw new TypeError( + "Return value from serve handler must not be an error response (like Response.error())", + ); + } + if (response.bodyUsed) { throw new TypeError( - "The body of the Response returned from the serve handler has already been consumed.", + "The body of the Response returned from the serve handler has already been consumed", ); } } catch (error) { -- cgit v1.2.3