From 4cfc54931d765a012b7836e60ba556d9c7b421ff Mon Sep 17 00:00:00 2001
From: Leo Kettmeir <crowlkats@toaxl.com>
Date: Tue, 11 Jul 2023 14:49:19 +0200
Subject: fix(node/http): allow callback in first argument of end call (#19778)

Closes #19762
---
 ext/node/polyfills/http.ts | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

(limited to 'ext')

diff --git a/ext/node/polyfills/http.ts b/ext/node/polyfills/http.ts
index e3419e88b..6a1ea7105 100644
--- a/ext/node/polyfills/http.ts
+++ b/ext/node/polyfills/http.ts
@@ -599,6 +599,15 @@ class ClientRequest extends OutgoingMessage {
 
   // deno-lint-ignore no-explicit-any
   end(chunk?: any, encoding?: any, cb?: any): this {
+    if (typeof chunk === "function") {
+      cb = chunk;
+      chunk = null;
+      encoding = null;
+    } else if (typeof encoding === "function") {
+      cb = encoding;
+      encoding = null;
+    }
+
     this.finished = true;
     if (chunk !== undefined && chunk !== null) {
       this.write(chunk, encoding);
@@ -617,12 +626,12 @@ class ClientRequest extends OutgoingMessage {
               }
 
               core.tryClose(this._bodyWriteRid);
+            }
 
-              try {
-                cb?.();
-              } catch (_) {
-                //
-              }
+            try {
+              cb?.();
+            } catch (_) {
+              //
             }
           })(),
         ]);
-- 
cgit v1.2.3