From 3a7abe6906c54f9c628215c2b71d67e8db25a519 Mon Sep 17 00:00:00 2001
From: Florian Schwalm <68847951+egfx-notifications@users.noreply.github.com>
Date: Sun, 12 Nov 2023 20:47:03 +0100
Subject: fix(ext/web): Prevent TextDecoderStream resource leak on stream
 cancellation (#21074)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR uses the new `cancel` method of `TransformStream` to properly
clean up the internal `TextDecoder` used in `TextDecoderStream` if the
stream is cancelled.

Fixes #13142

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
---
 ext/web/06_streams.js       | 4 ++++
 ext/web/08_text_encoding.js | 8 ++++++++
 2 files changed, 12 insertions(+)

(limited to 'ext')

diff --git a/ext/web/06_streams.js b/ext/web/06_streams.js
index c5306ca9c..7ce045e68 100644
--- a/ext/web/06_streams.js
+++ b/ext/web/06_streams.js
@@ -6680,6 +6680,10 @@ webidl.converters.Transformer = webidl
       key: "flush",
       converter: webidl.converters.Function,
     },
+    {
+      key: "cancel",
+      converter: webidl.converters.Function,
+    },
     {
       key: "readableType",
       converter: webidl.converters.any,
diff --git a/ext/web/08_text_encoding.js b/ext/web/08_text_encoding.js
index 45dbad538..5f8391e12 100644
--- a/ext/web/08_text_encoding.js
+++ b/ext/web/08_text_encoding.js
@@ -301,6 +301,14 @@ class TextDecoderStream {
           return PromiseReject(err);
         }
       },
+      cancel: (_reason) => {
+        try {
+          const _ = this.#decoder.decode();
+          return PromiseResolve();
+        } catch (err) {
+          return PromiseReject(err);
+        }
+      },
     });
     this[webidl.brand] = webidl.brand;
   }
-- 
cgit v1.2.3