From 32bbba3db29d503a681ad1617901ce9a0e908e86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Sun, 20 Aug 2023 12:02:47 +0200 Subject: perf(ext/event): always set timeStamp to 0 (#20191) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ```js Deno.bench(function eventNew() { new Event("foo"); }); ``` main ``` ./target/release/deno bench event_bench.js cpu: Apple M1 Max runtime: deno 1.36.1 (aarch64-apple-darwin) file:///Users/ib/dev/deno/event_bench.js benchmark time (avg) iter/s (min … max) p75 p99 p995 --------------------------------------------------------------- ----------------------------- eventNew 36.43 ns/iter 27,451,874.9 (35.15 ns … 46.98 ns) 37.68 ns 40.7 ns 41.69 ns ``` this PR ``` ./target/release/deno bench event_bench.js cpu: Apple M1 Max runtime: deno 1.36.1 (aarch64-apple-darwin) file:///Users/ib/dev/deno/event_bench.js benchmark time (avg) iter/s (min … max) p75 p99 p995 --------------------------------------------------------------- ----------------------------- eventNew 13.71 ns/iter 72,958,970.0 (12.85 ns … 31.79 ns) 15.11 ns 16.49 ns 17.5 ns ``` Towards #20167 --- ext/websocket/01_websocket.js | 2 -- 1 file changed, 2 deletions(-) (limited to 'ext/websocket') diff --git a/ext/websocket/01_websocket.js b/ext/websocket/01_websocket.js index 71abb0830..bb1624f22 100644 --- a/ext/websocket/01_websocket.js +++ b/ext/websocket/01_websocket.js @@ -9,7 +9,6 @@ import * as webidl from "ext:deno_webidl/00_webidl.js"; import { HTTP_TOKEN_CODE_POINT_RE } from "ext:deno_web/00_infra.js"; import DOMException from "ext:deno_web/01_dom_exception.js"; import { - _skipInternalInit, CloseEvent, defineEventHandler, dispatch, @@ -450,7 +449,6 @@ class WebSocket extends EventTarget { const event = new MessageEvent("message", { data, origin: this[_url], - [_skipInternalInit]: true, }); setIsTrusted(event, true); dispatch(this, event); -- cgit v1.2.3