From a3c5193a2e7d15bbfac390b220982561376e7322 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 12 Apr 2023 21:58:57 +0200 Subject: refactor(ext/webidl): remove object from 'requiredArguments' (#18674) This should produce a little less garbage and using an object here wasn't really required. --------- Co-authored-by: Aapo Alasuutari Co-authored-by: Leo Kettmeir --- ext/webidl/00_webidl.js | 6 ++---- ext/webidl/internal.d.ts | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'ext/webidl') diff --git a/ext/webidl/00_webidl.js b/ext/webidl/00_webidl.js index 43c0cb621..5f4a69240 100644 --- a/ext/webidl/00_webidl.js +++ b/ext/webidl/00_webidl.js @@ -642,11 +642,9 @@ converters["sequence"] = createSequenceConverter( converters.DOMString, ); -function requiredArguments(length, required, opts = {}) { +function requiredArguments(length, required, prefix) { if (length < required) { - const errMsg = `${ - opts.prefix ? opts.prefix + ": " : "" - }${required} argument${ + const errMsg = `${prefix ? prefix + ": " : ""}${required} argument${ required === 1 ? "" : "s" } required, but only ${length} present.`; throw new TypeError(errMsg); diff --git a/ext/webidl/internal.d.ts b/ext/webidl/internal.d.ts index fcd3e91ce..110031ae7 100644 --- a/ext/webidl/internal.d.ts +++ b/ext/webidl/internal.d.ts @@ -206,7 +206,7 @@ declare module "ext:deno_webidl/00_webidl.js" { function requiredArguments( length: number, required: number, - opts: ConverterOpts, + prefix: string, ): void; type Dictionary = DictionaryMember[]; interface DictionaryMember { -- cgit v1.2.3