From 696d528641ed6e03cf64daaee48bcc7c3fc8b89f Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Tue, 6 Aug 2024 00:40:17 -0700 Subject: fix(ext/web): make TextDecoderResource use cppgc (#24888) Fixes https://github.com/denoland/deno/issues/24878 --- ext/web/08_text_encoding.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'ext/web/08_text_encoding.js') diff --git a/ext/web/08_text_encoding.js b/ext/web/08_text_encoding.js index 9920a81f8..3163c9628 100644 --- a/ext/web/08_text_encoding.js +++ b/ext/web/08_text_encoding.js @@ -56,8 +56,8 @@ class TextDecoder { /** @type {boolean} */ #utf8SinglePass; - /** @type {number | null} */ - #rid = null; + /** @type {object | null} */ + #handle = null; /** * @param {string} label @@ -159,7 +159,7 @@ class TextDecoder { } // Fast path for single pass encoding. - if (!stream && this.#rid === null) { + if (!stream && this.#handle === null) { // Fast path for utf8 single pass encoding. if (this.#utf8SinglePass) { return op_encoding_decode_utf8(input, this.#ignoreBOM); @@ -173,18 +173,17 @@ class TextDecoder { ); } - if (this.#rid === null) { - this.#rid = op_encoding_new_decoder( + if (this.#handle === null) { + this.#handle = op_encoding_new_decoder( this.#encoding, this.#fatal, this.#ignoreBOM, ); } - return op_encoding_decode(input, this.#rid, stream); + return op_encoding_decode(input, this.#handle, stream); } finally { - if (!stream && this.#rid !== null) { - core.close(this.#rid); - this.#rid = null; + if (!stream && this.#handle !== null) { + this.#handle = null; } } } -- cgit v1.2.3