From f5c31b56e3fb57a92dbaaec17690bfa9d787164e Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Sun, 15 May 2022 13:27:56 +0200 Subject: Revert "core: don't include_str extension js code (#10786)" (#14614) This reverts commit 10e50a120744de71d6915af4ae93f8231607573d Alternative to #13217, IMO the tradeoffs made by #10786 aren't worth it. It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ... Closes #11030 --- ext/url/benches/url_ops.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'ext/url/benches') diff --git a/ext/url/benches/url_ops.rs b/ext/url/benches/url_ops.rs index ed27b6f80..315ea7260 100644 --- a/ext/url/benches/url_ops.rs +++ b/ext/url/benches/url_ops.rs @@ -11,9 +11,7 @@ fn setup() -> Vec { Extension::builder() .js(vec![( "setup", - Box::new(|| { - Ok(r#"const { URL } = globalThis.__bootstrap.url;"#.to_owned()) - }), + "const { URL } = globalThis.__bootstrap.url;", )]) .build(), ] -- cgit v1.2.3