From ce7dc2be92499f15b4b0315bfca3ee9d61fc3c5e Mon Sep 17 00:00:00 2001
From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Date: Tue, 9 Jul 2024 20:06:08 -0700
Subject: feat(node): Support executing npm package lifecycle scripts
 (preinstall/install/postinstall) (#24487)

Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.

With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.

Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).

When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.

Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry

---

TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes

---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
---
 ext/node/polyfills/process.ts | 5 ++++-
 ext/node/resolution.rs        | 8 +++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

(limited to 'ext/node')

diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts
index de48fea3e..ec8671122 100644
--- a/ext/node/polyfills/process.ts
+++ b/ext/node/polyfills/process.ts
@@ -408,7 +408,10 @@ Process.prototype.config = {
   target_defaults: {
     default_configuration: "Release",
   },
-  variables: {},
+  variables: {
+    llvm_version: "0.0",
+    enable_lto: "false",
+  },
 };
 
 /** https://nodejs.org/api/process.html#process_process_cwd */
diff --git a/ext/node/resolution.rs b/ext/node/resolution.rs
index 5b61c1642..2f0b9898d 100644
--- a/ext/node/resolution.rs
+++ b/ext/node/resolution.rs
@@ -1459,7 +1459,13 @@ fn resolve_bin_entry_value<'a>(
   };
   let bin_entry = match bin {
     Value::String(_) => {
-      if bin_name.is_some() && bin_name != package_json.name.as_deref() {
+      if bin_name.is_some()
+        && bin_name
+          != package_json
+            .name
+            .as_deref()
+            .map(|name| name.rsplit_once('/').map_or(name, |(_, name)| name))
+      {
         None
       } else {
         Some(bin)
-- 
cgit v1.2.3