From acd62786c24c38d8986475f0660d5205b55a9ad3 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Tue, 10 Sep 2024 17:00:08 -0700 Subject: fix(ext/node): Add missing `node:path` exports (#25567) Apparently `path/posix` and `path/win32` have circular exports. I do not know why. Additionally there's a deprecated function `_makeLong` which is just `toNamespacedPath` --- ext/node/polyfills/path/_posix.ts | 4 ++++ ext/node/polyfills/path/_win32.ts | 3 +++ ext/node/polyfills/path/mod.ts | 1 + ext/node/polyfills/path/posix.ts | 3 +++ ext/node/polyfills/path/win32.ts | 3 +++ 5 files changed, 14 insertions(+) (limited to 'ext/node') diff --git a/ext/node/polyfills/path/_posix.ts b/ext/node/polyfills/path/_posix.ts index 555b7dc6d..bf0b91d48 100644 --- a/ext/node/polyfills/path/_posix.ts +++ b/ext/node/polyfills/path/_posix.ts @@ -478,6 +478,9 @@ export function parse(path: string): ParsedPath { return ret; } + +export const _makeLong = toNamespacedPath; + export default { basename, delimiter, @@ -492,4 +495,5 @@ export default { resolve, sep, toNamespacedPath, + _makeLong, }; diff --git a/ext/node/polyfills/path/_win32.ts b/ext/node/polyfills/path/_win32.ts index b8fe241bb..11c82e0ee 100644 --- a/ext/node/polyfills/path/_win32.ts +++ b/ext/node/polyfills/path/_win32.ts @@ -953,6 +953,8 @@ export function parse(path: string): ParsedPath { return ret; } +export const _makeLong = toNamespacedPath; + export default { basename, delimiter, @@ -967,4 +969,5 @@ export default { resolve, sep, toNamespacedPath, + _makeLong, }; diff --git a/ext/node/polyfills/path/mod.ts b/ext/node/polyfills/path/mod.ts index 56d21d2e0..e74c1da4d 100644 --- a/ext/node/polyfills/path/mod.ts +++ b/ext/node/polyfills/path/mod.ts @@ -36,6 +36,7 @@ export const { resolve, sep, toNamespacedPath, + _makeLong, } = path; export default path; export * from "ext:deno_node/path/common.ts"; diff --git a/ext/node/polyfills/path/posix.ts b/ext/node/polyfills/path/posix.ts index 8e95ba124..2b6582ff6 100644 --- a/ext/node/polyfills/path/posix.ts +++ b/ext/node/polyfills/path/posix.ts @@ -18,6 +18,9 @@ export const { resolve, sep, toNamespacedPath, + _makeLong, } = path.posix; +export const posix = path.posix; +export const win32 = path.win32; export default path.posix; diff --git a/ext/node/polyfills/path/win32.ts b/ext/node/polyfills/path/win32.ts index 06806e81b..02e6f97c5 100644 --- a/ext/node/polyfills/path/win32.ts +++ b/ext/node/polyfills/path/win32.ts @@ -18,6 +18,9 @@ export const { resolve, sep, toNamespacedPath, + _makeLong, } = path.win32; +export const posix = path.posix; +export const win32 = path.win32; export default path.win32; -- cgit v1.2.3