From a938aaf36fde1ecf25fdbff323690c98c99a1ecc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 29 Aug 2022 19:48:27 +0200 Subject: fix(ext/node): better error for importing ES module via require() call (#15671) --- ext/node/02_require.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'ext/node') diff --git a/ext/node/02_require.js b/ext/node/02_require.js index 6f06d3269..99587472a 100644 --- a/ext/node/02_require.js +++ b/ext/node/02_require.js @@ -730,9 +730,15 @@ if (StringPrototypeEndsWith(filename, ".js")) { const pkg = core.ops.op_require_read_package_scope(filename); if (pkg && pkg.exists && pkg.typ == "module") { - throw new Error( - `Import ESM module: ${filename} from ${module.parent.filename}`, - ); + let message = `Trying to import ESM module: ${filename}`; + + if (module.parent) { + message += ` from ${module.parent.filename}`; + } + + message += ` using require()`; + + throw new Error(message); } } -- cgit v1.2.3