From 9d6da1036d80a29862f6bdfb51e6f51eee235c35 Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Wed, 7 Aug 2024 18:15:57 +0200 Subject: fix: `rename` watch event missing (#24893) This PR ensures that we forward a `rename` event in our file watcher. The rust lib we use combines that with the `modify` event. This fixes a compatibility issue with Node too, which sends the `rename` event as well. Fixes https://github.com/denoland/deno/issues/24880 --- ext/node/polyfills/_fs/_fs_watch.ts | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ext/node') diff --git a/ext/node/polyfills/_fs/_fs_watch.ts b/ext/node/polyfills/_fs/_fs_watch.ts index acdaff800..eb2cd8bfa 100644 --- a/ext/node/polyfills/_fs/_fs_watch.ts +++ b/ext/node/polyfills/_fs/_fs_watch.ts @@ -368,6 +368,8 @@ function convertDenoFsEventToNodeFsEvent( ): NodeFsEventType { if (kind === "create" || kind === "remove") { return "rename"; + } else if (kind === "rename") { + return "rename"; } else { return "change"; } -- cgit v1.2.3