From 9b2b8df927ac23cfa99016a684179f2a3198ba2e Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Thu, 1 Dec 2022 21:29:15 -0800 Subject: feat(ops): Fast zero copy string arguments (#16777) Uses SeqOneByteString optimization to do zero-copy `&str` arguments in fast calls. - [x] Depends on https://github.com/denoland/rusty_v8/pull/1129 - [x] Depends on https://chromium-review.googlesource.com/c/v8/v8/+/4036884 - [x] Disable in async ops - [x] Make it work with owned `String` with an extra alloc in fast path. - [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast case ```rust #[op] fn op_string_len(s: &str) -> u32 { str.len() as u32 } ``` --- ext/node/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ext/node') diff --git a/ext/node/lib.rs b/ext/node/lib.rs index b2443db0b..5282c0660 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -262,7 +262,7 @@ fn op_require_proxy_path(filename: String) -> String { } #[op] -fn op_require_is_request_relative(request: String) -> bool { +fn op_require_is_request_relative(request: &str) -> bool { if request.starts_with("./") || request.starts_with("../") || request == ".." { return true; -- cgit v1.2.3