From 427b73c3ec1e01ca8c670d403a85fcf31777d253 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 23 Jan 2024 15:33:07 +0100 Subject: feat: warn when using --unstable, prefer granular flags (#21452) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit deprecates "--unstable" flag. When "--unstable" flag is encountered a warning like this is printed: ``` The `--unstable` flag is deprecated, use granular `--unstable-*` flags instead. Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags ``` When "--unstable" flag is used and an unstable API is called an additional warning like this is printed for each API call: ``` The `Deno.dlopen` API was used with `--unstable` flag. The `--unstable` flag is deprecated, use granular `--unstable-ffi` instead. Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags ``` When no "--unstable-*" flag is provided and an unstable API is called following warning is issued before exiting: ``` Unstable API 'Deno.dlopen'. The `--unstable-ffi` flag must be provided. ``` --------- Signed-off-by: Divy Srivastava Signed-off-by: Bartek Iwańczuk Co-authored-by: Divy Srivastava Co-authored-by: Asher Gomez --- ext/node/polyfills/child_process.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ext/node') diff --git a/ext/node/polyfills/child_process.ts b/ext/node/polyfills/child_process.ts index 0f45230d9..c88266cbe 100644 --- a/ext/node/polyfills/child_process.ts +++ b/ext/node/polyfills/child_process.ts @@ -9,6 +9,7 @@ import { core, internals } from "ext:core/mod.js"; const { op_node_child_ipc_pipe, + op_bootstrap_unstable_args, } = core.ensureFastOps(); const { op_npm_process_state, @@ -130,7 +131,7 @@ export function fork( } args = [ "run", - "--unstable", // TODO(kt3k): Remove when npm: is stable + ...op_bootstrap_unstable_args(), "--node-modules-dir", "-A", ...stringifiedV8Flags, -- cgit v1.2.3