From 69387f0b0c4ac3be4ce88f9139d141cbc7da277b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 10 Aug 2023 20:19:20 +0200 Subject: fix(node): don't print warning on process.dlopen.flags (#20124) Closes https://github.com/denoland/deno/issues/20075 --- ext/node/polyfills/process.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'ext/node/polyfills') diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts index 2f1c2968f..4c375760d 100644 --- a/ext/node/polyfills/process.ts +++ b/ext/node/polyfills/process.ts @@ -292,11 +292,10 @@ function _kill(pid: number, sig: number): number { } } -// TODO(bartlomieju): flags is currently not supported. -export function dlopen(module, filename, flags) { - if (typeof flags !== "undefined") { - warnNotImplemented("process.dlopen doesn't support 'flags' argument"); - } +export function dlopen(module, filename, _flags) { + // NOTE(bartlomieju): _flags is currently ignored, but we don't warn for it + // as it makes DX bad, even though it might not be needed: + // https://github.com/denoland/deno/issues/20075 Module._extensions[".node"](module, filename); return module; } -- cgit v1.2.3