From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Sat, 4 Mar 2023 22:31:38 -0400
Subject: refactor(core): include_js_files! 'dir' option doesn't change
 specifiers (#18019)

This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".

Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
---
 ext/node/polyfills/readline/promises.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'ext/node/polyfills/readline')

diff --git a/ext/node/polyfills/readline/promises.ts b/ext/node/polyfills/readline/promises.ts
index 47e3b5b22..c8650dc23 100644
--- a/ext/node/polyfills/readline/promises.ts
+++ b/ext/node/polyfills/readline/promises.ts
@@ -1,28 +1,28 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
 // Copyright Joyent and Node contributors. All rights reserved. MIT license.
 
-import { Readline } from "internal:deno_node/polyfills/internal/readline/promises.mjs";
+import { Readline } from "internal:deno_node/internal/readline/promises.mjs";
 
 import {
   Interface as _Interface,
   kQuestion,
   kQuestionCancel,
-} from "internal:deno_node/polyfills/internal/readline/interface.mjs";
-import { AbortError } from "internal:deno_node/polyfills/internal/errors.ts";
-import { validateAbortSignal } from "internal:deno_node/polyfills/internal/validators.mjs";
+} from "internal:deno_node/internal/readline/interface.mjs";
+import { AbortError } from "internal:deno_node/internal/errors.ts";
+import { validateAbortSignal } from "internal:deno_node/internal/validators.mjs";
 
-import { kEmptyObject } from "internal:deno_node/polyfills/internal/util.mjs";
-import type { Abortable } from "internal:deno_node/polyfills/_events.d.ts";
+import { kEmptyObject } from "internal:deno_node/internal/util.mjs";
+import type { Abortable } from "internal:deno_node/_events.d.ts";
 import type {
   AsyncCompleter,
   Completer,
   ReadLineOptions,
-} from "internal:deno_node/polyfills/_readline_shared_types.d.ts";
+} from "internal:deno_node/_readline_shared_types.d.ts";
 
 import type {
   ReadableStream,
   WritableStream,
-} from "internal:deno_node/polyfills/_global.d.ts";
+} from "internal:deno_node/_global.d.ts";
 
 /**
  * The `readline/promise` module provides an API for reading lines of input from a Readable stream one line at a time.
-- 
cgit v1.2.3