From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Sat, 4 Mar 2023 22:31:38 -0400 Subject: refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019) This commit changes "include_js_files!" macro from "deno_core" in a way that "dir" option doesn't cause specifiers to be rewritten to include it. Example: ``` include_js_files! { dir "js", "hello.js", } ``` The above definition required embedders to use: `import ... from "internal:/js/hello.js"`. But with this change, the "js" directory in which the files are stored is an implementation detail, which for embedders results in: `import ... from "internal:/hello.js"`. The directory the files are stored in, is an implementation detail and in some cases might result in a significant size difference for the snapshot. As an example, in "deno_node" extension, we store the source code in "polyfills" directory; which resulted in each specifier to look like "internal:deno_node/polyfills/", but with this change it's "internal:deno_node/". Given that "deno_node" has over 100 files, many of them having several import specifiers to the same extension, this change removes 10 characters from each import specifier. --- ext/node/polyfills/internal_binding/stream_wrap.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'ext/node/polyfills/internal_binding/stream_wrap.ts') diff --git a/ext/node/polyfills/internal_binding/stream_wrap.ts b/ext/node/polyfills/internal_binding/stream_wrap.ts index 3aee3b9da..1f7d9f6c5 100644 --- a/ext/node/polyfills/internal_binding/stream_wrap.ts +++ b/ext/node/polyfills/internal_binding/stream_wrap.ts @@ -28,14 +28,14 @@ // - https://github.com/nodejs/node/blob/master/src/stream_wrap.cc import { TextEncoder } from "internal:deno_web/08_text_encoding.js"; -import { Buffer } from "internal:deno_node/polyfills/buffer.ts"; -import { notImplemented } from "internal:deno_node/polyfills/_utils.ts"; -import { HandleWrap } from "internal:deno_node/polyfills/internal_binding/handle_wrap.ts"; +import { Buffer } from "internal:deno_node/buffer.ts"; +import { notImplemented } from "internal:deno_node/_utils.ts"; +import { HandleWrap } from "internal:deno_node/internal_binding/handle_wrap.ts"; import { AsyncWrap, providerType, -} from "internal:deno_node/polyfills/internal_binding/async_wrap.ts"; -import { codeMap } from "internal:deno_node/polyfills/internal_binding/uv.ts"; +} from "internal:deno_node/internal_binding/async_wrap.ts"; +import { codeMap } from "internal:deno_node/internal_binding/uv.ts"; interface Reader { read(p: Uint8Array): Promise; -- cgit v1.2.3