From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Sat, 4 Mar 2023 22:31:38 -0400
Subject: refactor(core): include_js_files! 'dir' option doesn't change
 specifiers (#18019)

This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".

Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
---
 ext/node/polyfills/internal/dns/utils.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

(limited to 'ext/node/polyfills/internal/dns/utils.ts')

diff --git a/ext/node/polyfills/internal/dns/utils.ts b/ext/node/polyfills/internal/dns/utils.ts
index 0afd10617..238ede2a9 100644
--- a/ext/node/polyfills/internal/dns/utils.ts
+++ b/ext/node/polyfills/internal/dns/utils.ts
@@ -20,30 +20,30 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-import { getOptionValue } from "internal:deno_node/polyfills/internal/options.ts";
-import { emitWarning } from "internal:deno_node/polyfills/process.ts";
+import { getOptionValue } from "internal:deno_node/internal/options.ts";
+import { emitWarning } from "internal:deno_node/process.ts";
 import {
   AI_ADDRCONFIG,
   AI_ALL,
   AI_V4MAPPED,
-} from "internal:deno_node/polyfills/internal_binding/ares.ts";
+} from "internal:deno_node/internal_binding/ares.ts";
 import {
   ChannelWrap,
   strerror,
-} from "internal:deno_node/polyfills/internal_binding/cares_wrap.ts";
+} from "internal:deno_node/internal_binding/cares_wrap.ts";
 import {
   ERR_DNS_SET_SERVERS_FAILED,
   ERR_INVALID_ARG_VALUE,
   ERR_INVALID_IP_ADDRESS,
-} from "internal:deno_node/polyfills/internal/errors.ts";
-import type { ErrnoException } from "internal:deno_node/polyfills/internal/errors.ts";
+} from "internal:deno_node/internal/errors.ts";
+import type { ErrnoException } from "internal:deno_node/internal/errors.ts";
 import {
   validateArray,
   validateInt32,
   validateOneOf,
   validateString,
-} from "internal:deno_node/polyfills/internal/validators.mjs";
-import { isIP } from "internal:deno_node/polyfills/internal/net.ts";
+} from "internal:deno_node/internal/validators.mjs";
+import { isIP } from "internal:deno_node/internal/net.ts";
 
 export interface LookupOptions {
   family?: number | undefined;
-- 
cgit v1.2.3