From 08e5606c3400d3a993c0ce6748901c56fc3db35b Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Fri, 5 Jul 2024 10:10:22 +0200 Subject: fix(ext/node): rewrite digest handling (#24392) Previously we had many different code paths all handling digests in different places, all with wildly different digest support. This commit rewrites this to use a single digest handling mechanism for all digest operations. It adds various aliases for digest algorithms, like node does. For example `sha1WithRSAEncryption` is an alias for `sha1`. It also adds support for `md5-sha1` digests in various places. --- ext/node/polyfills/internal/crypto/sig.ts | 9 --------- 1 file changed, 9 deletions(-) (limited to 'ext/node/polyfills/internal/crypto/sig.ts') diff --git a/ext/node/polyfills/internal/crypto/sig.ts b/ext/node/polyfills/internal/crypto/sig.ts index 5a9611780..473670d2a 100644 --- a/ext/node/polyfills/internal/crypto/sig.ts +++ b/ext/node/polyfills/internal/crypto/sig.ts @@ -67,10 +67,6 @@ export class SignImpl extends Writable { algorithm = algorithm.toLowerCase(); - if (algorithm.startsWith("rsa-")) { - // Allows RSA-[digest_algorithm] as a valid algorithm - algorithm = algorithm.slice(4); - } this.#digestType = algorithm; this.hash = createHash(this.#digestType); } @@ -121,11 +117,6 @@ export class VerifyImpl extends Writable { algorithm = algorithm.toLowerCase(); - if (algorithm.startsWith("rsa-")) { - // Allows RSA-[digest_algorithm] as a valid algorithm - algorithm = algorithm.slice(4); - } - this.#digestType = algorithm; this.hash = createHash(this.#digestType); } -- cgit v1.2.3