From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Sat, 4 Mar 2023 22:31:38 -0400
Subject: refactor(core): include_js_files! 'dir' option doesn't change
 specifiers (#18019)

This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".

Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
---
 ext/node/polyfills/internal/child_process.ts | 40 +++++++++++++---------------
 1 file changed, 18 insertions(+), 22 deletions(-)

(limited to 'ext/node/polyfills/internal/child_process.ts')

diff --git a/ext/node/polyfills/internal/child_process.ts b/ext/node/polyfills/internal/child_process.ts
index 81a404c14..a96b97d9e 100644
--- a/ext/node/polyfills/internal/child_process.ts
+++ b/ext/node/polyfills/internal/child_process.ts
@@ -2,37 +2,33 @@
 
 // This module implements 'child_process' module of Node.JS API.
 // ref: https://nodejs.org/api/child_process.html
-import { assert } from "internal:deno_node/polyfills/_util/asserts.ts";
-import { EventEmitter } from "internal:deno_node/polyfills/events.ts";
-import { os } from "internal:deno_node/polyfills/internal_binding/constants.ts";
+import { assert } from "internal:deno_node/_util/asserts.ts";
+import { EventEmitter } from "internal:deno_node/events.ts";
+import { os } from "internal:deno_node/internal_binding/constants.ts";
 import {
   notImplemented,
   warnNotImplemented,
-} from "internal:deno_node/polyfills/_utils.ts";
-import {
-  Readable,
-  Stream,
-  Writable,
-} from "internal:deno_node/polyfills/stream.ts";
-import { deferred } from "internal:deno_node/polyfills/_util/async.ts";
-import { isWindows } from "internal:deno_node/polyfills/_util/os.ts";
-import { nextTick } from "internal:deno_node/polyfills/_next_tick.ts";
+} from "internal:deno_node/_utils.ts";
+import { Readable, Stream, Writable } from "internal:deno_node/stream.ts";
+import { deferred } from "internal:deno_node/_util/async.ts";
+import { isWindows } from "internal:deno_node/_util/os.ts";
+import { nextTick } from "internal:deno_node/_next_tick.ts";
 import {
   AbortError,
   ERR_INVALID_ARG_TYPE,
   ERR_INVALID_ARG_VALUE,
   ERR_UNKNOWN_SIGNAL,
-} from "internal:deno_node/polyfills/internal/errors.ts";
-import { Buffer } from "internal:deno_node/polyfills/buffer.ts";
-import { errnoException } from "internal:deno_node/polyfills/internal/errors.ts";
-import { ErrnoException } from "internal:deno_node/polyfills/_global.d.ts";
-import { codeMap } from "internal:deno_node/polyfills/internal_binding/uv.ts";
+} from "internal:deno_node/internal/errors.ts";
+import { Buffer } from "internal:deno_node/buffer.ts";
+import { errnoException } from "internal:deno_node/internal/errors.ts";
+import { ErrnoException } from "internal:deno_node/_global.d.ts";
+import { codeMap } from "internal:deno_node/internal_binding/uv.ts";
 import {
   isInt32,
   validateBoolean,
   validateObject,
   validateString,
-} from "internal:deno_node/polyfills/internal/validators.mjs";
+} from "internal:deno_node/internal/validators.mjs";
 import {
   ArrayIsArray,
   ArrayPrototypeFilter,
@@ -43,10 +39,10 @@ import {
   ArrayPrototypeUnshift,
   ObjectPrototypeHasOwnProperty,
   StringPrototypeToUpperCase,
-} from "internal:deno_node/polyfills/internal/primordials.mjs";
-import { kEmptyObject } from "internal:deno_node/polyfills/internal/util.mjs";
-import { getValidatedPath } from "internal:deno_node/polyfills/internal/fs/utils.mjs";
-import process from "internal:deno_node/polyfills/process.ts";
+} from "internal:deno_node/internal/primordials.mjs";
+import { kEmptyObject } from "internal:deno_node/internal/util.mjs";
+import { getValidatedPath } from "internal:deno_node/internal/fs/utils.mjs";
+import process from "internal:deno_node/process.ts";
 
 export function mapValues<T, O>(
   record: Readonly<Record<string, T>>,
-- 
cgit v1.2.3