From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Sat, 4 Mar 2023 22:31:38 -0400 Subject: refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019) This commit changes "include_js_files!" macro from "deno_core" in a way that "dir" option doesn't cause specifiers to be rewritten to include it. Example: ``` include_js_files! { dir "js", "hello.js", } ``` The above definition required embedders to use: `import ... from "internal:/js/hello.js"`. But with this change, the "js" directory in which the files are stored is an implementation detail, which for embedders results in: `import ... from "internal:/hello.js"`. The directory the files are stored in, is an implementation detail and in some cases might result in a significant size difference for the snapshot. As an example, in "deno_node" extension, we store the source code in "polyfills" directory; which resulted in each specifier to look like "internal:deno_node/polyfills/", but with this change it's "internal:deno_node/". Given that "deno_node" has over 100 files, many of them having several import specifiers to the same extension, this change removes 10 characters from each import specifier. --- ext/node/polyfills/_http_outgoing.ts | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'ext/node/polyfills/_http_outgoing.ts') diff --git a/ext/node/polyfills/_http_outgoing.ts b/ext/node/polyfills/_http_outgoing.ts index cb0312d4a..801570dd6 100644 --- a/ext/node/polyfills/_http_outgoing.ts +++ b/ext/node/polyfills/_http_outgoing.ts @@ -1,27 +1,27 @@ // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. // Copyright Joyent and Node contributors. All rights reserved. MIT license. -import { getDefaultHighWaterMark } from "internal:deno_node/polyfills/internal/streams/state.mjs"; -import assert from "internal:deno_node/polyfills/internal/assert.mjs"; -import EE from "internal:deno_node/polyfills/events.ts"; -import { Stream } from "internal:deno_node/polyfills/stream.ts"; -import { deprecate } from "internal:deno_node/polyfills/util.ts"; -import type { Socket } from "internal:deno_node/polyfills/net.ts"; +import { getDefaultHighWaterMark } from "internal:deno_node/internal/streams/state.mjs"; +import assert from "internal:deno_node/internal/assert.mjs"; +import EE from "internal:deno_node/events.ts"; +import { Stream } from "internal:deno_node/stream.ts"; +import { deprecate } from "internal:deno_node/util.ts"; +import type { Socket } from "internal:deno_node/net.ts"; import { kNeedDrain, kOutHeaders, utcDate, -} from "internal:deno_node/polyfills/internal/http.ts"; -import { Buffer } from "internal:deno_node/polyfills/buffer.ts"; +} from "internal:deno_node/internal/http.ts"; +import { Buffer } from "internal:deno_node/buffer.ts"; import { _checkInvalidHeaderChar as checkInvalidHeaderChar, _checkIsHttpToken as checkIsHttpToken, chunkExpression as RE_TE_CHUNKED, -} from "internal:deno_node/polyfills/_http_common.ts"; +} from "internal:deno_node/_http_common.ts"; import { defaultTriggerAsyncIdScope, symbols, -} from "internal:deno_node/polyfills/internal/async_hooks.ts"; +} from "internal:deno_node/internal/async_hooks.ts"; // deno-lint-ignore camelcase const { async_id_symbol } = symbols; import { @@ -39,11 +39,11 @@ import { ERR_STREAM_NULL_VALUES, ERR_STREAM_WRITE_AFTER_END, hideStackFrames, -} from "internal:deno_node/polyfills/internal/errors.ts"; -import { validateString } from "internal:deno_node/polyfills/internal/validators.mjs"; -import { isUint8Array } from "internal:deno_node/polyfills/internal/util/types.ts"; +} from "internal:deno_node/internal/errors.ts"; +import { validateString } from "internal:deno_node/internal/validators.mjs"; +import { isUint8Array } from "internal:deno_node/internal/util/types.ts"; -import { debuglog } from "internal:deno_node/polyfills/internal/util/debuglog.ts"; +import { debuglog } from "internal:deno_node/internal/util/debuglog.ts"; let debug = debuglog("http", (fn) => { debug = fn; }); -- cgit v1.2.3