From 96bc15dfa237b506c4f2d8bf1c041f25000e9878 Mon Sep 17 00:00:00 2001 From: Farsen976 Date: Thu, 16 Mar 2023 04:16:03 +0100 Subject: fix(ext/node): implement "ascii" encoding for node:fs writeFile() (#18097) --- ext/node/polyfills/_fs/_fs_common.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ext/node/polyfills/_fs') diff --git a/ext/node/polyfills/_fs/_fs_common.ts b/ext/node/polyfills/_fs/_fs_common.ts index c704cd975..19f0d7d17 100644 --- a/ext/node/polyfills/_fs/_fs_common.ts +++ b/ext/node/polyfills/_fs/_fs_common.ts @@ -74,7 +74,7 @@ export function checkEncoding(encoding: Encodings | null): Encodings | null { if (!encoding) return null; encoding = encoding.toLowerCase() as Encodings; - if (["utf8", "hex", "base64"].includes(encoding)) return encoding; + if (["utf8", "hex", "base64", "ascii"].includes(encoding)) return encoding; if (encoding === "utf-8") { return "utf8"; @@ -85,7 +85,7 @@ export function checkEncoding(encoding: Encodings | null): Encodings | null { // node -e "require('fs').readFile('../world.txt', 'buffer', console.log)" } - const notImplementedEncodings = ["utf16le", "latin1", "ascii", "ucs2"]; + const notImplementedEncodings = ["utf16le", "latin1", "ucs2"]; if (notImplementedEncodings.includes(encoding as string)) { notImplemented(`"${encoding}" encoding`); -- cgit v1.2.3