From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Sat, 4 Mar 2023 22:31:38 -0400
Subject: refactor(core): include_js_files! 'dir' option doesn't change
 specifiers (#18019)

This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".

Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
---
 ext/node/polyfills/_fs/_fs_common.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'ext/node/polyfills/_fs/_fs_common.ts')

diff --git a/ext/node/polyfills/_fs/_fs_common.ts b/ext/node/polyfills/_fs/_fs_common.ts
index 1e9f0f266..9b4a982bd 100644
--- a/ext/node/polyfills/_fs/_fs_common.ts
+++ b/ext/node/polyfills/_fs/_fs_common.ts
@@ -7,15 +7,15 @@ import {
   O_RDWR,
   O_TRUNC,
   O_WRONLY,
-} from "internal:deno_node/polyfills/_fs/_fs_constants.ts";
-import { validateFunction } from "internal:deno_node/polyfills/internal/validators.mjs";
-import type { ErrnoException } from "internal:deno_node/polyfills/_global.d.ts";
+} from "internal:deno_node/_fs/_fs_constants.ts";
+import { validateFunction } from "internal:deno_node/internal/validators.mjs";
+import type { ErrnoException } from "internal:deno_node/_global.d.ts";
 import {
   BinaryEncodings,
   Encodings,
   notImplemented,
   TextEncodings,
-} from "internal:deno_node/polyfills/_utils.ts";
+} from "internal:deno_node/_utils.ts";
 
 export type CallbackWithError = (err: ErrnoException | null) => void;
 
@@ -212,7 +212,7 @@ export function getOpenOptions(
   return openOptions;
 }
 
-export { isUint32 as isFd } from "internal:deno_node/polyfills/internal/validators.mjs";
+export { isUint32 as isFd } from "internal:deno_node/internal/validators.mjs";
 
 export function maybeCallback(cb: unknown) {
   validateFunction(cb, "cb");
-- 
cgit v1.2.3