From a8b4e346b4477e340f36a59f83a0974afd541f4b Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 26 Apr 2023 18:53:13 -0400 Subject: refactor(ext/node): use a snapshottable global name for Node's globalThis (#18860) --- ext/node/lib.rs | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) (limited to 'ext/node/lib.rs') diff --git a/ext/node/lib.rs b/ext/node/lib.rs index 84530423f..cc4afb2b8 100644 --- a/ext/node/lib.rs +++ b/ext/node/lib.rs @@ -169,15 +169,7 @@ pub trait NpmResolver: std::fmt::Debug + Send + Sync { ) -> Result<(), AnyError>; } -pub static NODE_GLOBAL_THIS_NAME: Lazy = Lazy::new(|| { - let now = std::time::SystemTime::now(); - let seconds = now - .duration_since(std::time::SystemTime::UNIX_EPOCH) - .unwrap() - .as_secs(); - // use a changing variable name to make it hard to depend on this - format!("__DENO_NODE_GLOBAL_THIS_{seconds}__") -}); +pub const NODE_GLOBAL_THIS_NAME: &str = env!("NODE_GLOBAL_THIS_NAME"); pub static NODE_ENV_VAR_ALLOWLIST: Lazy> = Lazy::new(|| { // The full list of environment variables supported by Node.js is available @@ -557,9 +549,7 @@ pub fn initialize_runtime( argv0 ); }})('{}', {}, {});"#, - NODE_GLOBAL_THIS_NAME.as_str(), - uses_local_node_modules_dir, - argv0 + NODE_GLOBAL_THIS_NAME, uses_local_node_modules_dir, argv0 ); js_runtime.execute_script(located_script_name!(), source_code.into())?; -- cgit v1.2.3