From e888c3f534c6ce9574f1d57e5cc61573a046039e Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Thu, 30 Mar 2023 20:57:21 +0200 Subject: feat(ext/kv): return versionstamp from set/commit (#18512) This commit updates the `Deno.Kv` API to return the new commited versionstamp for the mutated data from `db.set` and `ao.commit`. This is returned in the form of a `Deno.KvCommitResult` object that has a `versionstamp` property. --- ext/kv/sqlite.rs | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) (limited to 'ext/kv/sqlite.rs') diff --git a/ext/kv/sqlite.rs b/ext/kv/sqlite.rs index 17634127f..63be1281b 100644 --- a/ext/kv/sqlite.rs +++ b/ext/kv/sqlite.rs @@ -17,6 +17,7 @@ use rusqlite::OptionalExtension; use rusqlite::Transaction; use crate::AtomicWrite; +use crate::CommitResult; use crate::Database; use crate::DatabaseHandler; use crate::KvEntry; @@ -216,7 +217,10 @@ impl Database for SqliteDb { Ok(responses) } - async fn atomic_write(&self, write: AtomicWrite) -> Result { + async fn atomic_write( + &self, + write: AtomicWrite, + ) -> Result, AnyError> { let mut db = self.0.borrow_mut(); let tx = db.transaction()?; @@ -228,7 +232,7 @@ impl Database for SqliteDb { .optional()? .map(version_to_versionstamp); if real_versionstamp != check.versionstamp { - return Ok(false); + return Ok(None); } } @@ -273,7 +277,11 @@ impl Database for SqliteDb { tx.commit()?; - Ok(true) + let new_vesionstamp = version_to_versionstamp(version); + + Ok(Some(CommitResult { + versionstamp: new_vesionstamp, + })) } } -- cgit v1.2.3