From aa9b94a80eadde7737417eb7d412559bc567c77c Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Fri, 31 Mar 2023 21:28:21 +0530 Subject: perf(ext/websocket): use opAsync2 to avoid spread deopt (#18525) This commit adds a new core API `opAsync2` to call an async op with atmost 2 arguments. Spread argument iterators has a pretty big perf hit when calling ops. | name | avg msg/sec/core | | --- | --- | | 1.32.1 | `127820.750000` | | #18506 | `140079.000000` | | #18506 + #18509 | `150104.250000` | | #18506 + #18509 + this | `157340.000000` | --- ext/http/01_http.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ext/http') diff --git a/ext/http/01_http.js b/ext/http/01_http.js index 7e648017b..5b78bb2f2 100644 --- a/ext/http/01_http.js +++ b/ext/http/01_http.js @@ -316,7 +316,7 @@ function createRespondWith( break; } try { - await core.opAsync("op_http_write", streamRid, value); + await core.opAsync2("op_http_write", streamRid, value); } catch (error) { const connError = httpConn[connErrorSymbol]; if ( -- cgit v1.2.3