From 3487fde236d0852a8b0672c293fa41a741f471e8 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Fri, 17 Mar 2023 16:15:27 -0600 Subject: perf(core) Reduce copying and cloning in extension initialization (#18252) Follow-up to #18210: * we are passing the generated `cfg` object into the state function rather than passing individual config fields * reduce cloning dramatically by making the state_fn `FnOnce` * `take` for `ExtensionBuilder` to avoid more unnecessary copies * renamed `config` to `options` --- ext/ffi/lib.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'ext/ffi') diff --git a/ext/ffi/lib.rs b/ext/ffi/lib.rs index 1fd01c9d2..c11f08dd8 100644 --- a/ext/ffi/lib.rs +++ b/ext/ffi/lib.rs @@ -112,12 +112,12 @@ deno_core::extension!(deno_ffi, op_ffi_unsafe_callback_ref, ], esm = [ "00_ffi.js" ], - config = { + options = { unstable: bool, }, - state = |state, unstable| { + state = |state, options| { // Stolen from deno_webgpu, is there a better option? - state.put(Unstable(unstable)); + state.put(Unstable(options.unstable)); let (async_work_sender, async_work_receiver) = mpsc::unbounded::(); -- cgit v1.2.3