From 34a15545c979299b00c013e6634dfc3a79011b92 Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Sun, 26 Sep 2021 23:46:56 +0200 Subject: refactor(fetch/response): inline defaultInnerResponse (#12235) Not useful to have the defaults externally defined when they're only used in `newInnerResponse()`. Also match order in `newInnerResponse()` and `cloneInnerResponse` --- ext/fetch/23_response.js | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) (limited to 'ext/fetch') diff --git a/ext/fetch/23_response.js b/ext/fetch/23_response.js index 61e1de151..13710881f 100644 --- a/ext/fetch/23_response.js +++ b/ext/fetch/23_response.js @@ -101,37 +101,33 @@ type: response.type, body, headerList, - url() { - if (this.urlList.length == 0) return null; - return this.urlList[this.urlList.length - 1]; - }, urlList, status: response.status, statusMessage: response.statusMessage, aborted: response.aborted, + url() { + if (this.urlList.length == 0) return null; + return this.urlList[this.urlList.length - 1]; + }, }; } - const defaultInnerResponse = { - type: "default", - body: null, - aborted: false, - url() { - if (this.urlList.length == 0) return null; - return this.urlList[this.urlList.length - 1]; - }, - }; - /** * @returns {InnerResponse} */ function newInnerResponse(status = 200, statusMessage = "") { return { + type: "default", + body: null, headerList: [], urlList: [], status, statusMessage, - ...defaultInnerResponse, + aborted: false, + url() { + if (this.urlList.length == 0) return null; + return this.urlList[this.urlList.length - 1]; + }, }; } -- cgit v1.2.3