From 22e0ee92a6618db0168b9dfce6c598b6df207a4c Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Wed, 30 Dec 2020 22:35:28 +0000 Subject: BREAKING(unstable): Use hosts for net allowlists (#8845) Allowlist checking already uses hosts but for some reason requests, revokes and the runtime permissions API use URLs. - BREAKING(lib.deno.unstable.d.ts): Change NetPermissionDescriptor::url to NetPermissionDescriptor::host - fix(runtime/permissions): Don't add whole URLs to the allowlist on request - fix(runtime/permissions): Harden strength semantics: ({ name: "net", host: "127.0.0.1" } is stronger than { name: "net", host: "127.0.0.1:8000" }) for blocklisting - refactor(runtime/permissions): Use tuples for hosts, make the host optional in Permissions::{query_net, request_net, revoke_net}() --- docs/runtime/permission_apis.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'docs/runtime') diff --git a/docs/runtime/permission_apis.md b/docs/runtime/permission_apis.md index 14314035d..1b6f8096e 100644 --- a/docs/runtime/permission_apis.md +++ b/docs/runtime/permission_apis.md @@ -32,7 +32,7 @@ const desc2 = { name: "write", path: "foo/bar" } as const; const desc3 = { name: "net" } as const; // Net permission to 127.0.0.1:8000. -const desc4 = { name: "net", url: "127.0.0.1:8000" } as const; +const desc4 = { name: "net", host: "127.0.0.1:8000" } as const; // High-resolution time permission. const desc5 = { name: "hrtime" } as const; @@ -86,9 +86,9 @@ const desc1 = { name: "write" } as const; // is stronger than const desc2 = { name: "write", path: "/foo" } as const; -const desc3 = { name: "net" } as const; +const desc3 = { name: "net", host: "127.0.0.1" } as const; // is stronger than -const desc4 = { name: "net", url: "127.0.0.1:8000" } as const; +const desc4 = { name: "net", host: "127.0.0.1:8000" } as const; ``` ### Request permissions -- cgit v1.2.3