From 9b2b8df927ac23cfa99016a684179f2a3198ba2e Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Thu, 1 Dec 2022 21:29:15 -0800 Subject: feat(ops): Fast zero copy string arguments (#16777) Uses SeqOneByteString optimization to do zero-copy `&str` arguments in fast calls. - [x] Depends on https://github.com/denoland/rusty_v8/pull/1129 - [x] Depends on https://chromium-review.googlesource.com/c/v8/v8/+/4036884 - [x] Disable in async ops - [x] Make it work with owned `String` with an extra alloc in fast path. - [x] Support `Cow<'_, str>`. Owned for slow case, Borrowed for fast case ```rust #[op] fn op_string_len(s: &str) -> u32 { str.len() as u32 } ``` --- core/ops_builtin.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'core') diff --git a/core/ops_builtin.rs b/core/ops_builtin.rs index 6374e9951..858ce97bd 100644 --- a/core/ops_builtin.rs +++ b/core/ops_builtin.rs @@ -107,7 +107,7 @@ pub fn op_metrics(state: &mut OpState) -> (OpMetrics, Vec) { /// Builtin utility to print to stdout/stderr #[op] -pub fn op_print(msg: String, is_err: bool) -> Result<(), Error> { +pub fn op_print(msg: &str, is_err: bool) -> Result<(), Error> { if is_err { stderr().write_all(msg.as_bytes())?; stderr().flush().unwrap(); @@ -152,12 +152,12 @@ pub fn op_wasm_streaming_feed( pub fn op_wasm_streaming_set_url( state: &mut OpState, rid: ResourceId, - url: String, + url: &str, ) -> Result<(), Error> { let wasm_streaming = state.resource_table.get::(rid)?; - wasm_streaming.0.borrow_mut().set_url(&url); + wasm_streaming.0.borrow_mut().set_url(url); Ok(()) } -- cgit v1.2.3