From 878d092df9cc89ad92e571e2422ffb1ed488dd0e Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Tue, 11 Jun 2019 23:17:41 +0200 Subject: Revert "Work around Windows-only V8 concurrent initialization crash" This fix is no longer necessary as the underlying V8 bug has been fixed upstream. This reverts commit 48bcfce09e11901244447617be2eb7789427eab0. --- core/libdeno/api.cc | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) (limited to 'core') diff --git a/core/libdeno/api.cc b/core/libdeno/api.cc index bcdf7131b..8a3a56156 100644 --- a/core/libdeno/api.cc +++ b/core/libdeno/api.cc @@ -5,10 +5,6 @@ #include #include -// Cpplint bans the use of because it duplicates functionality in -// chromium //base. However Deno doensn't use that, so suppress this lint. -#include // NOLINT - #include "third_party/v8/include/libplatform/libplatform.h" #include "third_party/v8/include/v8.h" #include "third_party/v8/src/base/logging.h" @@ -57,20 +53,7 @@ Deno* deno_new(deno_config config) { params.snapshot_blob = &d->snapshot_; } - v8::Isolate* isolate; - { -#ifdef _WIN32 - // Work around an apparent V8 bug where initializing multiple isolates - // concurrently leads to a crash. At the time of writing the cause of this - // crash is not exactly understood, but it seems to be related to the V8 - // internal function win64_unwindinfo::RegisterNonABICompliantCodeRange(), - // which didn't exist in older versions of V8. - static std::mutex mutex; - std::lock_guard lock(mutex); -#endif - isolate = v8::Isolate::New(params); - } - + v8::Isolate* isolate = v8::Isolate::New(params); d->AddIsolate(isolate); v8::Locker locker(isolate); -- cgit v1.2.3