From 8744ee883e093ecc09add4054177f8afa793ec77 Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Sun, 15 May 2022 17:52:32 +0200 Subject: perf(core): optimize encode on large strings (#14619) Follow up to serde_v8's #14450 --- core/bindings.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'core') diff --git a/core/bindings.rs b/core/bindings.rs index 9d376fc0e..d2335d49c 100644 --- a/core/bindings.rs +++ b/core/bindings.rs @@ -896,11 +896,11 @@ fn encode( return; } }; - let text_str = text.to_rust_string_lossy(scope); - let bytes: Box<[u8]> = text_str.into_bytes().into_boxed_slice(); + let text_str = serde_v8::to_utf8(text, scope); + let bytes = text_str.into_bytes(); let len = bytes.len(); let backing_store = - v8::ArrayBuffer::new_backing_store_from_boxed_slice(bytes).make_shared(); + v8::ArrayBuffer::new_backing_store_from_vec(bytes).make_shared(); let buffer = v8::ArrayBuffer::with_backing_store(scope, &backing_store); let u8array = v8::Uint8Array::new(scope, buffer, 0, len).unwrap(); rv.set(u8array.into()) -- cgit v1.2.3