From 5dbc07935d47eaad48ba0a7b1a816c644f9446cd Mon Sep 17 00:00:00 2001 From: David Sherret Date: Tue, 6 Dec 2022 15:58:18 -0500 Subject: fix(test): handle scenario where --trace-ops would cause an unhandled promise rejection (#16970) Closes #16969 --- core/01_core.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'core') diff --git a/core/01_core.js b/core/01_core.js index 5df11c382..02150674e 100644 --- a/core/01_core.js +++ b/core/01_core.js @@ -187,8 +187,8 @@ // Rethrow the error throw err; } - handleOpCallTracing("${name}", id, promise); - promise[promiseIdSymbol] = id; + promise = handleOpCallTracing("${name}", id, promise); + promise[promiseIdSymbol] = id; return promise; } `, @@ -218,10 +218,12 @@ if (opCallTracingEnabled) { const stack = StringPrototypeSlice(new Error().stack, 6); MapPrototypeSet(opCallTraces, promiseId, { opName, stack }); - p = PromisePrototypeFinally( + return PromisePrototypeFinally( p, () => MapPrototypeDelete(opCallTraces, promiseId), ); + } else { + return p; } } -- cgit v1.2.3