From 68bf43fca7990d4e623b66243c2840ca7f0c3628 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Tue, 17 May 2022 20:49:55 +0530 Subject: feat(core): deterministic snapshots (#14037) --- core/runtime.rs | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) (limited to 'core/runtime.rs') diff --git a/core/runtime.rs b/core/runtime.rs index f8afeb76c..476267a94 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -204,7 +204,10 @@ impl Drop for JsRuntime { } } -fn v8_init(v8_platform: Option>) { +fn v8_init( + v8_platform: Option>, + predictable: bool, +) { // Include 10MB ICU data file. #[repr(C, align(16))] struct IcuData([u8; 10284336]); @@ -222,7 +225,15 @@ fn v8_init(v8_platform: Option>) { " --harmony-import-assertions", " --no-validate-asm", ); - v8::V8::set_flags_from_string(flags); + + if predictable { + v8::V8::set_flags_from_string(&format!( + "{}{}", + flags, " --predictable --random-seed=42" + )); + } else { + v8::V8::set_flags_from_string(flags); + } } #[derive(Default)] @@ -251,6 +262,7 @@ pub struct RuntimeOptions { pub startup_snapshot: Option, /// Prepare runtime to take snapshot of loaded code. + /// The snapshot is determinstic and uses predictable random numbers. /// /// Currently can't be used with `startup_snapshot`. pub will_snapshot: bool, @@ -284,7 +296,7 @@ impl JsRuntime { let v8_platform = options.v8_platform.take(); static DENO_INIT: Once = Once::new(); - DENO_INIT.call_once(move || v8_init(v8_platform)); + DENO_INIT.call_once(move || v8_init(v8_platform, options.will_snapshot)); let has_startup_snapshot = options.startup_snapshot.is_some(); -- cgit v1.2.3