From 8e84dc0139055db8c84ad28723114d343982a8f7 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Wed, 31 May 2023 08:19:06 -0600 Subject: chore(core): Split JsRuntimeForSnapshot from JsRuntime (#19308) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This cleans up `JsRuntime` a bit more: * We no longer print cargo's rerun-if-changed messages in `JsRuntime` -- those are printed elsewhere * We no longer special case the OwnedIsolate for snapshots. Instead we make use of an inner object that has the `Drop` impl and allows us to `std::mem::forget` it if we need to extract the isolate for a snapshot * The `snapshot` method is only available on `JsRuntimeForSnapshot`, not `JsRuntime`. * `OpState` construction is slightly cleaner, though I'd still like to extract more --------- Co-authored-by: Bartek Iwańczuk --- core/realm.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'core/realm.rs') diff --git a/core/realm.rs b/core/realm.rs index fc0ff4b4b..94ce77464 100644 --- a/core/realm.rs +++ b/core/realm.rs @@ -162,7 +162,7 @@ impl JsRealmInner { }; let exception = v8::Local::new(scope, handle); - let state_rc = JsRuntime::state(scope); + let state_rc = JsRuntime::state_from(scope); let state = state_rc.borrow(); if let Some(inspector) = &state.inspector { let inspector = inspector.borrow(); -- cgit v1.2.3