From f2c50fae844b34cf6d8488ab1fbc599eb935a919 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Thu, 20 Jun 2019 09:04:34 -0700 Subject: Fix silent failure of WebAssembly.instantiate() (#2548) By making WASM compilation synchronous. We'll have to do more work to make it properly async. --- core/libdeno/api.cc | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'core/libdeno/api.cc') diff --git a/core/libdeno/api.cc b/core/libdeno/api.cc index 8a3a56156..13057aeae 100644 --- a/core/libdeno/api.cc +++ b/core/libdeno/api.cc @@ -117,6 +117,13 @@ void deno_init() { platform = v8::platform::NewDefaultPlatform(); v8::V8::InitializePlatform(platform.get()); v8::V8::Initialize(); + // TODO(ry) This makes WASM compile synchronously. Eventually we should + // remove this to make it work asynchronously too. But that requires getting + // PumpMessageLoop and RunMicrotasks setup correctly. + // See https://github.com/denoland/deno/issues/2544 + const char* argv[2] = {"", "--no-wasm-async-compilation"}; + int argc = 2; + v8::V8::SetFlagsFromCommandLine(&argc, const_cast(argv), false); } } -- cgit v1.2.3