From dda0f1c343bfb3196ce6a7c7e8c2acccfd5c2e5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 22 Jun 2023 23:37:56 +0200 Subject: refactor(serde_v8): split ZeroCopyBuf into JsBuffer and ToJsBuffer (#19566) `ZeroCopyBuf` was convenient to use, but sometimes it did hide details that some copies were necessary in certain cases. Also it made it way to easy for the caller to pass around and convert into different values. This commit splits `ZeroCopyBuf` into `JsBuffer` (an array buffer coming from V8) and `ToJsBuffer` (a Rust buffer that will be converted into a V8 array buffer). As a result some magical conversions were removed (they were never used) limiting the API surface and preparing for changes in #19534. --- core/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'core/lib.rs') diff --git a/core/lib.rs b/core/lib.rs index ddc4d6d91..1f069e661 100644 --- a/core/lib.rs +++ b/core/lib.rs @@ -32,9 +32,10 @@ pub use serde_json; pub use serde_v8; pub use serde_v8::ByteString; pub use serde_v8::DetachedBuffer; +pub use serde_v8::JsBuffer; pub use serde_v8::StringOrBuffer; +pub use serde_v8::ToJsBuffer; pub use serde_v8::U16String; -pub use serde_v8::ZeroCopyBuf; pub use sourcemap; pub use url; pub use v8; -- cgit v1.2.3