From 161cf7cdfd44ace8937fb7940727984990742d18 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 3 Feb 2020 18:08:44 -0500 Subject: refactor: Use Tokio's single-threaded runtime (#3844) This change simplifies how we execute V8. Previously V8 Isolates jumped around threads every time they were woken up. This was overly complex and potentially hurting performance in a myriad ways. Now isolates run on their own dedicated thread and never move. - blocking_json spawns a thread and does not use a thread pool - op_host_poll_worker and op_host_resume_worker are non-operational - removes Worker::get_message and Worker::post_message - ThreadSafeState::workers table contains WorkerChannel entries instead of actual Worker instances. - MainWorker and CompilerWorker are no longer Futures. - The multi-threaded version of deno_core_http_bench was removed. - AyncOps no longer need to be Send + Sync This PR is very large and several tests were disabled to speed integration: - installer_test_local_module_run - installer_test_remote_module_run - _015_duplicate_parallel_import - _026_workers --- core/examples/http_bench.rs | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) (limited to 'core/examples') diff --git a/core/examples/http_bench.rs b/core/examples/http_bench.rs index 8151c4575..fa570acfb 100644 --- a/core/examples/http_bench.rs +++ b/core/examples/http_bench.rs @@ -164,27 +164,18 @@ fn main() { isolate.register_op("write", http_op(op_write)); isolate.register_op("close", http_op(op_close)); - let multi_thread = args.iter().any(|a| a == "--multi-thread"); - println!( "num cpus; logical: {}; physical: {}", num_cpus::get(), num_cpus::get_physical() ); - let mut builder = tokio::runtime::Builder::new(); - let builder = if multi_thread { - println!("multi-thread"); - builder.threaded_scheduler() - } else { - println!("single-thread"); - builder.basic_scheduler() - }; - let mut runtime = builder - .enable_io() + let mut runtime = tokio::runtime::Builder::new() + .basic_scheduler() + .enable_all() .build() - .expect("Unable to create tokio runtime"); - let result = runtime.block_on(isolate.boxed()); + .unwrap(); + let result = runtime.block_on(isolate.boxed_local()); js_check(result); } -- cgit v1.2.3