From fb358380c0570103619b0ce71c7fcb1b5a17986c Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Wed, 3 Feb 2021 11:40:43 +0100
Subject: fix: improve http client builder error message (#9380)

Include the lower-level error message in the generic error message.

No test because I can't actually make it fail by passing it bad PEM.
I checked and `reqwest::Certificate::from_pem()` always returns `Ok()`.

Fixes #9364.
---
 cli/http_util.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'cli')

diff --git a/cli/http_util.rs b/cli/http_util.rs
index 5b6274309..437b9355c 100644
--- a/cli/http_util.rs
+++ b/cli/http_util.rs
@@ -34,8 +34,9 @@ pub fn create_http_client(
 
   builder
     .build()
-    .map_err(|_| generic_error("Unable to build http client"))
+    .map_err(|e| generic_error(format!("Unable to build http client: {}", e)))
 }
+
 /// Construct the next uri based on base uri and location header fragment
 /// See <https://tools.ietf.org/html/rfc3986#section-4.2>
 fn resolve_url_from_location(base_url: &Url, location: &str) -> Url {
-- 
cgit v1.2.3